Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TransactionId argument to TransactionReceipt::fromProtobuf() #512

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Add TransactionId argument to TransactionReceipt::fromProtobuf() #512

merged 2 commits into from
Oct 3, 2023

Conversation

rwalworth
Copy link
Contributor

Description:
This PR adds a TransactionId argument to TransactionReceipt::fromProtobuf so that the TransactionId can be saved when deserializing a proto::TransactionGetReceiptResponse.

Related issue(s):

Fixes #506

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@rwalworth rwalworth added the Bug A error that causes the feature to behave differently than what was expected based on design docs label Oct 3, 2023
@rwalworth rwalworth requested a review from deyanzz October 3, 2023 18:26
@rwalworth rwalworth self-assigned this Oct 3, 2023
@rwalworth rwalworth linked an issue Oct 3, 2023 that may be closed by this pull request
Getting TransactionId from a TransactionReceipt returns [email protected] #506
Closed
deyanzz
deyanzz approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@deyanzz deyanzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rwalworth rwalworth force-pushed the 00506-getting-transactionid-from-a-transactionreceipt-returns-00000 branch from d313e3d to cb58649 Compare October 3, 2023 20:11
@rwalworth rwalworth merged commit 5d9fb9a into main Oct 3, 2023
2 of 3 checks passed
@rwalworth rwalworth deleted the 00506-getting-transactionid-from-a-transactionreceipt-returns-00000 branch October 3, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deyanzz deyanzz deyanzz approved these changes

Assignees

@rwalworth rwalworth

Labels
Bug A error that causes the feature to behave differently than what was expected based on design docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting TransactionId from a TransactionReceipt returns [email protected]
2 participants
@rwalworth @deyanzz